feat(cli): add mcp prompt support via slash commands #1323
+1,567
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new endpoints `list_prompts` and `get_prompt` in the MCP client - update prompt model in mcp-core to make `description` and `arguments` optional, following MCP spec
salman1993
reviewed
Feb 21, 2025
| @@ -70,9 +70,9 @@ pub fn load_prompt_files() -> HashMap<String, Prompt> { | |||
| description: arg.description, | |||
| required: arg.required, | |||
| }) | |||
| .collect(); | |||
| .collect::<Vec<PromptArgument>>(); | |||
There was a problem hiding this comment.
unrelated to this PR: i don't think we need this mapping - https://github.com/block/goose/blob/main/crates/goose-mcp/src/developer/prompts/unit_test.json
it'd be easier to stay closer to the MCP prompt in the json to avoid this mapping (description instead of template)
salman1993
approved these changes
Feb 21, 2025
|
nit: you can add a prompt in the mcp-server example here: https://github.com/modelcontextprotocol/rust-sdk/blob/main/crates/mcp-server/src/main.rs. that'll make it easier to test from this mcp-client example: https://github.com/modelcontextprotocol/rust-sdk/blob/main/crates/mcp-client/examples/stdio_integration.rs |
…e implementing types to define them, similar to other methods
… test both new methods
- extend CLI input handling to support `/prompts` for listing available prompts - add `ListPrompts` variant in the input enum and update help documentation - implement prompt rendering in the session output module - update agent traits and capabilities to aggregate and list prompts from all extensions
|
Moved this back into a draft PR for now, since we're in progress of moving the mcp stuff to the rust-sdk, I'm keeping the commits in sync manually for now but I'll hold off on diverging for nwo. |
fix: cherry-pick conflicts resolved
|
Added some basic cli based prompting scaffolding, mainly to list prompts and get the information about them. Calling the prompt is not yet implemented. Ex: ( O)> /prompts
mcp_test
- no_args_prompt
- one_arg_prompt
developer
- unit_test
( O)> /prompt unit_test --info
Extension: developer
Prompt: unit_test
Generate or update unit tests for a given source code file.
The source code file is provided in {source_code}.
Please update the existing tests, ensure they are passing, and add any new tests as needed.
The test suite should:
- Follow language-specific test naming conventions for {language}
- Include all necessary imports and annotations
- Thoroughly test the specified functionality
- Ensure tests are passing before completion
- Handle edge cases and error conditions
- Use clear test names that reflect what is being tested
Arguments:
source_code (required) The source code file content to be tested
language (required) The programming language of the source code
( O)>With prompt execution support: /prompt unit_test source_code="~/stage/unit_test/file.py" language=python
# Unit Test Generation and Update
I'll help you generate or update unit tests for the source code file at `~/stage/unit_test/file.py`. First, let me check if this file exists and examine its c
ontents to understand what we need to test.
─── shell | developer ──────────────────────────
command: ls -la ~stage/unit_test/
...
Now, let's run the existing tests to see if they pass:
─── shell | developer ──────────────────────────
command: cd /Users/kalvin/stage/unit_test/ && python -m unittest test_file.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.005s
OK
Great! The existing tests are already passing. Let's analyze the current test coverage and see if we need to add any additional tests:
...
However, we can enhance the test suite with a few additional tests:
1. Test reading a file with special characters
2. Test reading a file with different encodings
3. Test reading a large file (performance test)
Let's update the test file with these additional tests:
─── text_editor | developer ──────────────────────────
path: ~/stage/unit_test/test_file.py |
from the mcp server
agent loop Add functionality to transform PromptMessageContent to MessageContent with proper handling in the session module and add test coverage. Add the results of GetPrompt to the message conversation and run the agent loop with prompt response.
fix: update process_agent_response call
kalvinnchau
force-pushed
the
kalvin/mcp-prompt
branch
from
34bb93a to
a1ef0b9
Compare
kalvinnchau
changed the title
- introduce `GooseCompleter` in `completion.rs` implementing rustyline traits (Completer, Hinter, Highlighter, Validator, Helper) for CLI command completions - add helper methods for completing slash commands, prompt names, flags, and argument keys - update `Session` in `mod.rs` to include a thread-safe completion cache with update and invalidate functionality - derive `Clone` for `PromptInfo` in `output.rs` to support caching
- Test slash command, prompt name, flag, and argument completion - Match assertions to actual implementation behavior - Document edge cases in test comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update
Promptstructs for align with MCP spec, add basic prompt commands to mcp-clientdescriptionandargumentsare optional fields, use optional in the structsPromptArgumentsdescriptionandrequiredare optional toolist_promptsandget_promptmethod to theMcpClientTraitlist_promptsandget_promptto callprompts/listandprompts/getrespectivelystdioandsseclients to handleJsonRpcMessage::Errorresponses to send back to the user instead of doing nothing